fix: set networkConfiguration to null when using bridge network mode #617
Conversation
| @@ -48,10 +48,10 @@ async function runTask(ecs, clusterName, taskDefArn, waitForMinutes) { | |||
| awsvpcConfiguration["securityGroups"] = securityGroupIds.split(',') | |||
| } | |||
|
|
|||
| if(assignPublicIP != ""){ | |||
| if(assignPublicIP != "" && (subnetIds != "" || securityGroupIds != "")){ | |||
There was a problem hiding this comment.
I think, we should call this out in the action.yml file. in the description of assignPublicIP field.
It would also be great if we could add a line describing the difference in networkconfiguration for different launch types.
There was a problem hiding this comment.
ok great, I made a few readme + actions.yml description changes. let me know what you think!
amazreech
changed the title
|
Thank you for the PR!
For this, I am thinking if it should be enough to call this out in the README. Mostly because: For LaunchType
|
Issue #, if available:
#616
Description of changes:
This PR sets networkConfiguration to null when neither subnetIds nor securityGroupIds are set. This fixes run task whenever launch type is EC2. I tested this branch with the github workflow I'm building and it works to run migrations as a task.
There was one failing test which I changed. I wonder whether this should only apply when the launchType is EC2 though? Let me know what you think
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.